On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: > usb-storage is a compound device that automatically creates a USB mass > storage device and a SCSI device as its backend. Unfortunately it lacks > some configuration options that are usually present with a SCSI device, > and cannot represent CD-ROM in particular. > > Replace usb-storage with usb-bot, which can be combined with a manually > created SCSI device. libvirt will configure the SCSI device in a way > identical with how QEMU does for usb-storage except that now it respects > a configuration option to represent CD-ROM. Is this change compatible for QEMU's VMState aka migration ABI compatible ? > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/368 > Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> > --- > src/qemu/qemu_alias.c | 3 +- > src/qemu/qemu_capabilities.c | 2 +- > src/qemu/qemu_command.c | 55 ++++++++++++++++++++-- > src/qemu/qemu_command.h | 5 ++ > src/qemu/qemu_hotplug.c | 34 ++++++++++--- > src/qemu/qemu_validate.c | 4 +- > tests/qemuhotplugtest.c | 8 +++- > .../qemuxmlconfdata/disk-cache.x86_64-latest.args | 3 +- > .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- > .../disk-device-removable.x86_64-latest.args | 3 +- > .../disk-usb-device.x86_64-latest.args | 3 +- > 11 files changed, 102 insertions(+), 21 deletions(-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
