Re: [PATCH 1/2] ch: memory (segmentation fault) fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Please use the commit message mainly to describe the problem you're
> fixiing. You only described what you changed; not why.
> 
Thank you for your feedback, next time will keep it mind.

> 
> and it is weird because you do unref it here ...
> 
This unref executes in case of any failure during new thread start up, as it wont be used later, otherwise this reference is used by virCHEventHandlerLoop thread and should be unrefed when virCHEventHandlerLoop is finished.

> 
> ... but remove it from here.
>
In case of successful startup we do not want to unref an object cause it will be used in other thread.



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux