Re: [PATCH v2 1/4] tests: Remove pseries-2.7 machine type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 04, 2025 at 10:40:21 -0500, Narayana Murty N wrote:
> Support for the pseries-2.7 machine type in QEMU was
> officially removed in version 9.2 with commit 445d3facffe8.
> 
> Signed-off-by: Narayana Murty N <nnmlinux@xxxxxxxxxxxxx>
> ---

[...]

> diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
> index 8632434760..f2e319e390 100644
> --- a/tests/qemuxmlconftest.c
> +++ b/tests/qemuxmlconftest.c
> @@ -2927,8 +2927,6 @@ mymain(void)
>  
>      DO_TEST_CAPS_ARCH_LATEST("aarch64-default-cpu-kvm-virt-4.2", "aarch64");
>      DO_TEST_CAPS_ARCH_LATEST("aarch64-default-cpu-tcg-virt-4.2", "aarch64");
> -    DO_TEST_CAPS_ARCH_LATEST("ppc64-default-cpu-kvm-pseries-2.7", "ppc64");
> -    DO_TEST_CAPS_ARCH_LATEST("ppc64-default-cpu-tcg-pseries-2.7", "ppc64");

Alternatively you can pin the tests to the latest version that does
support given machine type changing this to using DP_TEST_CAPS_ARCH_VER instead.

If you thing there's no value in doing so please also add the reasoning
to the commit message.

>      DO_TEST_CAPS_ARCH_LATEST("ppc64-default-cpu-kvm-pseries-3.1", "ppc64");
>      DO_TEST_CAPS_ARCH_LATEST("ppc64-default-cpu-tcg-pseries-3.1", "ppc64");
>      DO_TEST_CAPS_ARCH_LATEST("ppc64-default-cpu-kvm-pseries-4.2", "ppc64");
> -- 
> 2.48.1
> 



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux