On Tue, Mar 04, 2025 at 14:04:05 +0000, Daniel P. Berrangé wrote:
> Contrary to most APIs returning typed parameters, there are no constants
> defined for the domain stats data keys. This is was because many of the
> keys needs to be dynamically constructed using one or more array index
> values.
>
> It is possible to define constants while still supporting dynamic
> array indexes by simply defining the prefixes and suffixes as constants.
> The consuming code can then combine the constants with array index
> value.
>
> With this approach, it is practical to add constants for the domain stats
> API keys.
>
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
> include/libvirt/libvirt-domain.h | 136 +++++++++++++++++++++++++++++++
> src/libvirt-domain.c | 36 +-------
> src/qemu/qemu_driver.c | 34 ++++----
> 3 files changed, 156 insertions(+), 50 deletions(-)
>
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index 7e9f998f2f..562bc6e17e 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -2930,6 +2930,142 @@ struct _virDomainStatsRecord {
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
