On Fri, Feb 28, 2025 at 17:18:42 +0100, Peter Krempa wrote: > In case when user provides custom paths (those not covered by the JSON > firmware descriptor files or the default locations) for the > loader and nvram template no auto-detection will be performed and user's > config will be taken at face value. Historically when 'templateFormat' > didn't exist we assumed that the 'format' field covers both. > > Thus if 'templateFormat' is VIR_STORAGE_FILE_NONE we need to skip the > check forbidding image format conversion for 'file' backed to avoid > breaking legacy configs with manual/non-detected format assuming that > user picked the correct format. > > Add a comment to the declaration of 'nvramTemplateFormat' noting the > above for future reference. > > Resolves: https://issues.redhat.com/browse/RHEL-81731 > Fixes: 2aa644a2fc8 > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/conf/domain_conf.h | 7 +++++++ > src/qemu/qemu_process.c | 5 ++++- > 2 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
