Re: [PATCH v2] Fix potential NULL dereference in remoteDomainMigratePrepare2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > --- a/src/remote/remote_driver.c
> > +++ b/src/remote/remote_driver.c
> > @@ -2849,17 +2849,34 @@ remoteDomainMigratePrepare2 (virConnectPtr dconn,
> >          goto done;
> >  
> >      if (ret.cookie.cookie_len > 0) {
> > +        if (!cookie || !cookielen) {
> > +            remoteError(VIR_ERR_INTERNAL_ERROR, "%s",
> > +                        _("caller ignores cookie or cookielen"));
> > +            goto error;
> > +        }
...
> 
> ACK; looks nicer than v1 for diagnosing a logic bug in the caller,
> rather than papering over it.

Thanks, pushed.

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]