On Tue, Feb 11, 2025 at 11:29:06PM -0500, Laine Stump wrote:
It can't fail.
Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
---
src/conf/domain_conf.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 611b6a44c8..d3e95a2f92 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -17200,7 +17200,7 @@ virDomainFeaturesDefParse(virDomainDef *def,
}
-static int
+static void
virDomainDefMaybeAddHostdevSCSIcontroller(virDomainDef *def)
{
/* Look for any hostdev scsi dev */
@@ -17227,12 +17227,10 @@ virDomainDefMaybeAddHostdevSCSIcontroller(virDomainDef *def)
}
if (maxController == -1)
- return 0;
+ return;
If `i` was ssize_t instead of size_t, you could've even removed the above condition, so maybe I'm glad that it's size_t because that for loop below would then gross me out =D Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
