Alexander Shursha wrote:
> Signed-off-by: Alexander Shursha <kekek2@xxxxx>
> ---
> src/bhyve/bhyve_command.c | 24 ++++++++++++++++
> .../bhyvexml2argv-passthru.args | 9 ++++++
> .../bhyvexml2argv-passthru.ldargs | 4 +++
> .../bhyvexml2argv-passthru.xml | 28 +++++++++++++++++++
> tests/bhyvexml2argvtest.c | 1 +
> 5 files changed, 66 insertions(+)
> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.args
> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.ldargs
> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.xml
>
> diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
> index bc287307c8..23bb2cdcf4 100644
> --- a/src/bhyve/bhyve_command.c
> +++ b/src/bhyve/bhyve_command.c
> @@ -2,6 +2,7 @@
> * bhyve_command.c: bhyve command generation
> *
> * Copyright (C) 2014 Roman Bogorodskiy
> + * Copyright (C) 2024-2025 Future Crew, LLC
> *
> * This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Lesser General Public
> @@ -152,6 +153,26 @@ bhyveBuildConsoleArgStr(const virDomainDef *def, virCommand *cmd)
> return 0;
> }
>
> +static int
> +bhyveBuildHostdevArgStr(const virDomainDef *def, virCommand *cmd)
> +{
> + size_t i;
> +
> + for (i = 0; i < def->nhostdevs; i++) {
> + virDomainHostdevDef *hostdev = def->hostdevs[i];
> + virDomainHostdevSubsys *subsys = &hostdev->source.subsys;
> +
> + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
> + subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
> + continue;
Looks like the error reporting was removed from here, but wasn't added
to bhyveDomainDeviceDefValidate() as per the previous suggestion.
Otherwise, this patch looks good to me.
Roman
