Re: [PATCH] qemu: forbid a few unsupported things for vhost-user/passt interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 21, 2025 at 02:06:42 -0500, Laine Stump wrote:
> passt in vhost-user mode doesn't support using multiple queues.
> 
> The path of the socket is auto-generated by libvirt for
> vhost-user/passt; it can't be set by the user
> 
> The passt end of a vhost-user socket is always the server, and the
> qemu end is always a client.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---
>  src/qemu/qemu_validate.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
> index 3e3e368da3..53affcdcff 100644
> --- a/src/qemu/qemu_validate.c
> +++ b/src/qemu/qemu_validate.c
> @@ -1824,6 +1824,22 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNetDef *net,
>          net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST) {
>          if (qemuValidateDomainDefVhostUserRequireSharedMemory(def, "interface type=\"vhostuser\" backend type=\"passt\"") < 0)
>              return -1;
> +
> +        if (net->driver.virtio.queues > 0) {
> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                           _("interface type=\"vhostuser\" backend type=\"passt\" does not support multiple queues"));

In our XML formatter we use single quotes for XML attribute value, in
order to not have to escape stuff.



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux