On Thu, Feb 20, 2025 at 11:59:00 +0100, Ján Tomko wrote: > On a Wednesday in 2025, Peter Krempa wrote: > > The original NEWS entry for the vTPM transient VM crash was rather > > vague and non-actionable. > > > > Apologies for not making it more descriptive. > > > I'm not convinced the NEWS should contain step-by-step workarounds for > bugs that are already fixed - that already happened in the linked issue. Well fair enough. I'll modify the patch to link to the issue instead. > > > As the bug is still actively experienced by users [1] of distros that > > didn't yet ship an update to v11.0.0 and is hit by relatively common > > usage improve the entry to mention situations when it happens a bit more > > close and provide workarounds for users who are not able to update. > > > > [1]: https://gitlab.com/libvirt/libvirt/-/issues/746 > > > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > --- > > NEWS.rst | 29 ++++++++++++++++++++++++++--- > > 1 file changed, 26 insertions(+), 3 deletions(-) > > > > diff --git a/NEWS.rst b/NEWS.rst > > index 7dc6a3fa37..117287044a 100644 > > --- a/NEWS.rst > > +++ b/NEWS.rst > > @@ -97,10 +97,33 @@ v11.0.0 (2025-01-15) > > > > * **Bug fixes** > > > > - * qemu: tpm: do not update profile name for transient domains > > + * qemu: tpm: Fix crash on startup of transient domains with vTPM > > > > The commit summary is already pushed and immutable. A news entry does not at all have to deal with the commit summary or whatever you wrote. The NEWS entry should describe the issue. The commit message may make sense in technical terms but it doesn't really suit the news entry in this case. It doesn't mention that it's a crash. Users see a crash and that should be mentioned here.
