Re: [PATCH 08/13] conf: Validate that iohtreads are used only with 'virtio-scsi' controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In the commit summary:
*iothreads

On a Friday in 2025, Peter Krempa wrote:
The documentation states:

``iothread``
   Supported for controller type ``scsi`` using model ``virtio-scsi`` for
   ``address`` types ``pci`` and ``ccw`` :since:`since 1.3.5 (QEMU 2.4)`. The

The code itself didn't validate if iothread is specified for any other
controller type.

Add test case showing the issue on one example.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/conf/domain_validate.c                    | 11 ++++++++
...r-virtio-serial-iothread.x86_64-latest.err |  1 +
.../controller-virtio-serial-iothread.xml     | 27 +++++++++++++++++++
tests/qemuxmlconftest.c                       |  2 ++
4 files changed, 41 insertions(+)
create mode 100644 tests/qemuxmlconfdata/controller-virtio-serial-iothread.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/controller-virtio-serial-iothread.xml


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux