On a Thursday in 2025, Peter Krempa wrote:
The workers of qemuDomainGetStats should not report errors if they can't fetch data; but rather omit the entries. Refactor the code to de-incentivize error reporting. Peter Krempa (21): qemuDomainGetStatsBlockExportHeader: Remove return value qemuDomainGetStatsBlockExportFrontend: Remove return value qemuDomainGetStatsBlockExportBackendStorage: Remove return value qemuDomainGetStatsOneBlockFallback: Remove return value qemuDomainGetStatsOneBlock: Remove return value qemuDomainStorageAlias: Remove NULL checks from callers qemuDomainGetStatsBlockExportHeader: Remove return value virBitmapFormat: Clarify returned values virDomainResctrlMonDefParse: Refactor temporary variables virDomainCputuneDefFormat: Refactor bitmap formatting virBitmapFormat: Don't check return value qemuDomainGetStatsCpuCgroup: Remove return value qemuDomainGetStatsCpuProc: Remove return value qemuDomainGetStatsCpuHaltPollTime: Remove return value qemuDomainGetStatsCpuCache: Don't error out virPerfReadEvent: Refactor to return -errno on failure qemuDomainGetStatsPerfOneEvent: Ignore erros from 'virPerfReadEvent' qemuDomainGetStatsIOThread: Don't error out if fetching iothread info fails qemuDomainGetStatsMemoryBandwidth: Don't error out qemuDomainGetStatsDirtyRate: Don't error out qemuDomainGetStats: Convert worker functions to void src/ch/ch_driver.c | 3 +- src/conf/capabilities.c | 9 +- src/conf/domain_conf.c | 69 ++----- src/conf/numa_conf.c | 18 +- src/conf/virnetworkobj.c | 3 - src/hypervisor/domain_cgroup.c | 6 +- src/libxl/libxl_driver.c | 3 +- src/libxl/xen_common.c | 6 +- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_driver.c | 341 ++++++++++++--------------------- src/qemu/qemu_monitor_json.c | 5 +- src/util/virbitmap.c | 11 +- src/util/vircgroup.c | 5 +- src/util/virperf.c | 19 +- src/vz/vz_sdk.c | 3 +- 16 files changed, 178 insertions(+), 336 deletions(-)
s/outputing/outputting/ in the commit messages Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
