On 05/18/2010 06:17 AM, Jim Meyering wrote:
> For each of the other uses of virDomainSaveStatus, the caller
> handles failure. Here it was ignored.
>
> At first I was inclined to simply "goto endjob;", like a few other
> uses in this file, but probing a bit, I found a few paths by which
> it could fail with no diagnostic whatsoever. And even if we've
> already emitted a diagnostic about some lower-level failure, it
> probably helps the user to know what high-level operation failed.
Makes sense.
> qemuDomainObjExitMonitorWithDriver(driver, vm);
> vm->state = VIR_DOMAIN_RUNNING;
> - virDomainSaveStatus(driver->caps, driver->stateDir, vm);
> + if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) {
> + VIR_WARN("Failed to save status on vm %s", vm->def->name);
Merge conflict with your patch to translate all VIR_WARN?
At any rate, ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list