On Fri, Feb 14, 2025 at 03:48:16PM -0700, Jim Fehlig via Devel wrote:
> Allow use of the enum outside of qemu_saveimage.
>
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> src/qemu/qemu_saveimage.c | 19 -------------------
> src/qemu/qemu_saveimage.h | 19 +++++++++++++++++++
> 2 files changed, 19 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> diff --git a/src/qemu/qemu_saveimage.h b/src/qemu/qemu_saveimage.h
> index 53ae222467..8e755e1eb5 100644
> --- a/src/qemu/qemu_saveimage.h
> +++ b/src/qemu/qemu_saveimage.h
> @@ -32,6 +32,25 @@
>
> G_STATIC_ASSERT(sizeof(QEMU_SAVE_MAGIC) == sizeof(QEMU_SAVE_PARTIAL));
>
> +typedef enum {
> + QEMU_SAVE_FORMAT_RAW = 0,
> + QEMU_SAVE_FORMAT_GZIP = 1,
> + QEMU_SAVE_FORMAT_BZIP2 = 2,
> + /*
> + * Deprecated by xz and never used as part of a release
> + * QEMU_SAVE_FORMAT_LZMA
> + */
As a separate commit we can cull that comment. We don't need to record
the fact we deleted that years ago before it ever it was ever visible
to users.
> + QEMU_SAVE_FORMAT_XZ = 3,
> + QEMU_SAVE_FORMAT_LZOP = 4,
> + QEMU_SAVE_FORMAT_ZSTD = 5,
> + /* Note: add new members only at the end.
> + These values are used in the on-disk format.
> + Do not change or re-use numbers. */
> +
> + QEMU_SAVE_FORMAT_LAST
> +} virQEMUSaveFormat;
> +VIR_ENUM_DECL(qemuSaveFormat);
> +
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
