On 05/18/2010 04:18 AM, Jim Meyering wrote:
> Fix a minor leak:
>
>>From 0fc88bfcae06346e871d2a4a89febb160bc0857e Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@xxxxxxxxxx>
> Date: Tue, 18 May 2010 12:17:23 +0200
> Subject: [PATCH] qemuMonitorTextMigrate: avoid leak on OOM-error path
>
> * src/qemu/qemu_monitor_text.c (qemuMonitorTextMigrate): Also
> free "safedest" buffer when failing.
> ---
> src/qemu/qemu_monitor_text.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
> index ae5d4d2..ec3d69d 100644
> --- a/src/qemu/qemu_monitor_text.c
> +++ b/src/qemu/qemu_monitor_text.c
> @@ -1149,6 +1149,7 @@ static int qemuMonitorTextMigrate(qemuMonitorPtr mon,
> if (virBufferError(&extra)) {
> virBufferFreeAndReset(&extra);
> virReportOOMError();
> + free(safedest);
> return -1;
ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list