On Wed, Feb 12, 2025 at 05:41:41PM +0100, Peter Krempa wrote:
> On Wed, Feb 12, 2025 at 15:46:39 +0000, Daniel P. Berrangé wrote:
> > This allows for passinga NULL connection object in cases where
> > domain autodestroy is not required.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > src/bhyve/bhyve_driver.c | 6 +++---
> > src/bhyve/bhyve_process.c | 5 ++---
> > src/bhyve/bhyve_process.h | 3 ++-
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> > index 8f97ac032c..ea5a9be4fb 100644
> > --- a/src/bhyve/bhyve_driver.c
> > +++ b/src/bhyve/bhyve_driver.c
> > @@ -79,7 +79,7 @@ bhyveAutostartDomain(virDomainObj *vm, void *opaque)
> >
> > if (vm->autostart && !virDomainObjIsActive(vm)) {
> > virResetLastError();
> > - ret = virBhyveProcessStart(data->conn, vm,
> > + ret = virBhyveProcessStart(bhyve_driver, data->conn, vm,
>
> This function already gets the driver passed in data->driver so you
> don't need to access the global variable.
This changes in the next patch, but yeah, makes sense to use data->driver
meanwhile
>
>
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
