On Wed, Jan 29, 2025 at 05:40:30PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
>
> Like VNC, allow to set credentials for RDP.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> ---
> src/conf/domain_conf.c | 13 +++++++++++++
> src/conf/domain_conf.h | 2 ++
> src/conf/schemas/domaincommon.rng | 10 ++++++++++
> 3 files changed, 25 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index ba1a495764..e5c2c2157c 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -1903,6 +1903,7 @@ typedef enum {
> } virDomainGraphicsAuthConnectedType;
>
> struct _virDomainGraphicsAuthDef {
> + char *username;
> char *passwd;
> bool expires; /* Whether there is an expiry time set */
> time_t validTo; /* seconds since epoch */
> @@ -2027,6 +2028,7 @@ struct _virDomainGraphicsDef {
> bool autoport;
> bool replaceUser;
> bool multiUser;
> + virDomainGraphicsAuthDef auth;
Similar observation as the previous patch that we ought not to be storing
the password in plain text directly in the XML. Everywhere except <graphics>
we reference out of band secrets for getting credentials. We should fix the
graphics XML one day to allow that too. Not something you need to fix.
> } rdp;
> struct {
> char *display;
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
