On Wed, Feb 12, 2025 at 02:54:17PM +0300, Alexander Shursha wrote: > Daniel P. Berrangé <berrange@xxxxxxxxxx> writes: > > Should I remove Sponsored from the commit log and add Copyright to the > file? > > * virpci.c: helper APIs for managing host PCI devices > * > * Copyright (C) 2009-2015 Red Hat, Inc. > + * Copyright (C) 2024-2025 Future Crew, LLC That depends on the terms of your work with Future Crew ie whether you have assigned your copyright over to them. As a project, we don't require contributors provide explicit Copyright lines on files. Some companies require their employees to do that, others don't. We just defer to contributors to comply with whatever rules they are working under in respect of 'Copyright' notices in files. > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > > > Please provide a commit message that describes the problem > > you're solving with this refactoring. Likewise for other > > commits in this series which all have empty commit messages. > > > >> Sponsored by: Future Crew, LLC > > > > While it is nice that they're sponsoring you to work on this, > > IMHO, we don't need to be advertizing commercial relationships > > in the commit log. > > > > It suffices to put such a note in the cover letter when sending a > > patch series. > > -- > Alexander Shursha > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
