[PATCH 15/17] conf: change virDomainDefMaybeAddVirtioSerialController() to return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It can't fail.

Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
---
 src/conf/domain_conf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c056abb28f..fe816dfd6d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -22270,7 +22270,7 @@ virDomainDefAddDiskControllersForType(virDomainDef *def,
 }
 
 
-static int
+static void
 virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
 {
     /* Look for any virtio serial or virtio console devs */
@@ -22299,8 +22299,6 @@ virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
             virDomainDefMaybeAddController(def, VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL, idx, -1);
         }
     }
-
-    return 0;
 }
 
 
@@ -22357,8 +22355,7 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
     virDomainDefAddDiskControllersForType(def, VIR_DOMAIN_CONTROLLER_TYPE_SATA,
                                           VIR_DOMAIN_DISK_BUS_SATA);
 
-    if (virDomainDefMaybeAddVirtioSerialController(def) < 0)
-        return -1;
+    virDomainDefMaybeAddVirtioSerialController(def);
 
     if (virDomainDefMaybeAddSmartcardController(def) < 0)
         return -1;
-- 
2.47.1




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux