On Mon, Feb 10, 2025 at 11:16:54 -0000, Harikumar Rajkumar wrote: > > On Fri, Feb 07, 2025 at 04:59:49 -0000, Harikumar Rajkumar wrote: > > It is an implementation detail how that is achieved, based on what qemu > > provides: > > - explicitly request qemu to revert to default > > - query the default and set the same value as default > > - refuse to do something that is not possible > > > > > > The API needs to allow a way that overwrites the full config including a > > way to return to the default. > > We have changed the implementation to allowing full config SET. > > Below six fields are set to default 1 by QEMU if omitted by user, are you suggesting to store this default value in XML by query the default in QEMU while SET? Not necessarily. The issue is that if you set a non-default value you'll most likely won't be able to query the original state. This'd require us to instantiate the object with defaults and then set it via monitor during startup. While possible that'll overcomplicate things most likely. > total_bytes_sec_max_length: 1 > read_bytes_sec_max_length: 1 > write_bytes_sec_max_length: 1 > total_iops_sec_max_length: 1 > read_iops_sec_max_length: 1 > write_iops_sec_max_length: 1 Ideally; if you want to express the full power of the API you need a way to re-set this to default in qemu. I didn't have a look if it's possible to do without querying the default first though. Either way, for the initial impl you can also implement a check that will require the users to provide a value if it already was non-default. I just want to leave the possibility open for the API to do full reset semantics if somebody will be willing to implement them.
