Pass also the 'writable' state to the fake passed FDs so that we can test it. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- tests/qemuxmlconftest.c | 6 +++--- tests/testutilsqemu.c | 2 ++ tests/testutilsqemu.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 3ddb19a7ed..99c4efc9d6 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -1655,9 +1655,9 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-backing-chains-noindex"); DO_TEST_CAPS_LATEST("disk-qcow2-datafile-store"); DO_TEST_CAPS_ARCH_LATEST_FULL("disk-source-fd", "x86_64", - ARG_FD_GROUP, "testgroup2", 2, 200, 205, - ARG_FD_GROUP, "testgroup5", 1, 204, - ARG_FD_GROUP, "testgroup6", 2, 247, 248); + ARG_FD_GROUP, "testgroup2", false, 2, 200, 205, + ARG_FD_GROUP, "testgroup5", false, 1, 204, + ARG_FD_GROUP, "testgroup6", false, 2, 247, 248); DO_TEST_CAPS_LATEST("disk-slices"); DO_TEST_CAPS_LATEST("disk-rotation"); diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index abc425b9b7..44011c2b36 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -704,11 +704,13 @@ testQemuInfoSetArgs(testQemuInfo *info, virStorageSourceFDTuple *new = virStorageSourceFDTupleNew(); const char *fdname = va_arg(argptr, char *); VIR_AUTOCLOSE fakefd = open("/dev/zero", O_RDWR); + bool writable = va_arg(argptr, int); size_t i; new->nfds = va_arg(argptr, unsigned int); new->fds = g_new0(int, new->nfds); new->testfds = g_new0(int, new->nfds); + new->writable = writable; for (i = 0; i < new->nfds; i++) { new->testfds[i] = va_arg(argptr, unsigned int); diff --git a/tests/testutilsqemu.h b/tests/testutilsqemu.h index 74e307d653..20135b8390 100644 --- a/tests/testutilsqemu.h +++ b/tests/testutilsqemu.h @@ -49,7 +49,7 @@ typedef enum { ARG_CAPS_VER, ARG_CAPS_VARIANT, ARG_CAPS_HOST_CPU_MODEL, - ARG_FD_GROUP, /* name, nfds, fd[0], ... fd[n-1] */ + ARG_FD_GROUP, /* name, writable, nfds, fd[0], ... fd[n-1] */ ARG_VDPA_FD, /* vdpadev, fd */ ARG_NBDKIT_CAPS, ARG_END, -- 2.48.1