On Mon, Feb 03, 2025 at 09:29:52 -0000, Harikumar Rajkumar wrote: > > On Mon, Nov 18, 2024 at 19:24:24 +0530, Harikumar R wrote: > > This will most likely need to be reimplemented by querying the data from > > the XML as the API itself IMO doesn't make too much sense to exist as it > > simply queries what we've set. > > are you suggesting to use qemuDomainGetXMLDesc() to get the data instead of qemuDomainGetThrottleGroup->qemuMonitorGetThrottleGroup->qemuMonitorJSONGetThrottleGroup() Yes. My argumentation is that qemuDomainGetThrottleGroup() API shouldn't really exist: - the values in QEMU should be exactly what was configured, if not it's a bug - thus the API will return exactly the same values as configured in the XML -> making the API pointless, as it returns same data as qemuDomainGetXMLDesc() As of such, no information will be lost by not having the getter API. Also as noted the implementation of the getter API was flawed. If you have reasons other than "it's done for symmetry" and "the old throttling API has a getter" please use it as justification for keeping the API but I currently don't see a reason to have a getter.
