Re: [PATCH v2 11/15] virDomainObjGetMessages: Refactor using GPtrArray

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2025 at 05:28:15PM +0100, Peter Krempa wrote:
> Simplify the function especially by rewriting it using GPtrArray to
> construct the string list, especially for the upcoming case when the
> number of added elements will not be known beforehand and when
> hypervisor specific data will be added.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c   | 36 +++++++-----------------------------
>  src/conf/domain_conf.h   |  4 ++--
>  src/libxl/libxl_driver.c |  9 ++++++++-
>  src/qemu/qemu_driver.c   |  9 ++++++++-
>  src/test/test_driver.c   |  9 ++++++++-
>  5 files changed, 33 insertions(+), 34 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux