Re: [PATCH v2 07/15] virStorageSource: Add fields for storing last I/O error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2025 at 05:28:11PM +0100, Peter Krempa wrote:
> Hypervisors may report a I/O error message (unstable; for human use)
> to libvirt. In order to store it with the appropriate virStorageSource
> so that it can be later queried we need to add fields to
> virStorageSource to store the timestamp and message.
> 
> The message is deliberately not copied via virStorageSourceCopy.
> 
> The messages are also not serialized to the status XML as losing them on
> a daemon restart as they're likely to be stale anyways.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/conf/storage_source_conf.c | 5 +++++
>  src/conf/storage_source_conf.h | 6 ++++++
>  2 files changed, 11 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux