On Wed, Jan 29, 2025 at 05:11:25PM +0100, Jiri Denemark wrote: > On Wed, Jan 29, 2025 at 15:46:30 +0000, Daniel P. Berrangé wrote: > > We previously added a sysusers file, but missed the 'libvirt' group. > > This group is referenced in the polkit rules, so we should be > > registering that too. It must be done in a separate sysusers file, > > however, since it is common to all daemons. > > > > Fixes: a2c3e390f7bedf36f4ddc544d09fe3b8772c5c6f > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > libvirt.spec.in | 1 + > > src/remote/libvirt.sysusers.conf | 1 + > > src/remote/meson.build | 7 +++++++ > > 3 files changed, 9 insertions(+) > > create mode 100644 src/remote/libvirt.sysusers.conf > > The specfile also creates a virtlogin which is not mentioned in any > sysuers file either. Sigh, yet more. Wll send a followup for that. > > Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx> > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
