Re: [PATCH v2 12/15] virDomainGetMessages: Introduce VIR_DOMAIN_MESSAGE_IOERRORS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2025 at 17:28:16 +0100, Peter Krempa wrote:
> Report any stored I/O error messages reported by the hypervisor when
> reporting messages of a domain. As the I/O error may be already stale we
> report also the timestamp when it was recorded.
> 
> Example message:
> 
>  I/O error: disk='vda', index='1', path='/dev/mapper/errdev0', timestamp='2025-01-28 15:47:52.776+0000', message'Input/output error'

Missing = after 'message'

> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---



> +static void
> +virDomainObjGetMessagesIOErrorsSrc(virStorageSource *src,
> +                                   const char *diskdst,
> +                                   GPtrArray *m)
> +{
> +    if (!src ||
> +        !src->ioerror_message)
> +        return;
> +
> +    g_ptr_array_add(m, g_strdup_printf(_("I/O error: disk='%1$s', index='%2$d', path='%3$s', timestamp='%4$s', message'%5$s'"),

here.

> +                                       NULLSTR_MINUS(diskdst),
> +                                       src->id,
> +                                       NULLSTR_MINUS(src->path),
> +                                       src->ioerror_timestamp,
> +                                       src->ioerror_message));
> +}



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux