On 05/17/2010 04:09 PM, Eric Blake wrote: > On 05/17/2010 01:38 PM, Cole Robinson wrote: >> A fedora translator filed: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=580816 >> >> Pointing out these two error messages as unclear: "write save" sounds >> like a typo without context, and lack of a colon made the second message >> difficult to parse. >> >> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> >> --- >> src/qemu/qemu_driver.c | 8 +++++--- >> 1 files changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >> index 582fdee..9ae8307 100644 >> --- a/src/qemu/qemu_driver.c >> +++ b/src/qemu/qemu_driver.c >> @@ -4805,7 +4805,8 @@ static int qemudDomainSaveFileOpHook(int fd, void *data) { >> if (safewrite(fd, hdata->header, sizeof(*hdata->header)) != sizeof(*hdata->header)) { >> ret = errno; >> qemuReportError(VIR_ERR_OPERATION_FAILED, >> - _("failed to write save header to '%s'"), hdata->path); >> + _("failed to write domain save file header to '%s'"), > > Four consecutive nouns isn't much easier to parse. What about: > > failed to write header to domain save file '%s' Yes, that's much better. Clearly I should spend more effort correcting my own incoherent sentences :) I've pushed this patch with your suggested change. Thanks, Cole > >> if (statfs_ret == -1) { >> virReportSystemError(errno, >> - _("Failed to create domain save file '%s'" >> - " statfs of all elements of path failed."), >> + _("Failed to create domain save file " >> + "'%s': statfs of all elements of path " >> + "failed"), > > This one's good (and nice that you nuked the trailing '.') > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list