Re: [PATCH 4/8] qemu_caps: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW

Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx> · Mon, 27 Jan 2025 13:42:36 +0100

Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx>

On 1/24/25 13:21, Michal Privoznik wrote:
This capability tracks whether QEMU supports virtio-mem-ccw
device. Introduced in QEMU commit v9.2.0-492-gaa910c20ec only
upcoming release of QEMU supports the device.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
  src/qemu/qemu_capabilities.c                     | 2 ++
  src/qemu/qemu_capabilities.h                     | 1 +
  tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml | 1 +
  3 files changed, 4 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 53aa64a009..b712906998 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -725,6 +725,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
  
                /* 470 */
                "migrate-incoming.exit-on-error", /* QEMU_CAPS_MIGRATE_INCOMING_EXIT_ON_ERROR */
+              "virtio-mem-ccw", /* QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW */
      );
  
  
@@ -1413,6 +1414,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
      { "virtio-sound-device", QEMU_CAPS_DEVICE_VIRTIO_SOUND },
      { "sev-snp-guest", QEMU_CAPS_SEV_SNP_GUEST },
      { "acpi-erst", QEMU_CAPS_DEVICE_ACPI_ERST },
+    { "virtio-mem-ccw", QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW },
  };
  
  
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 398749a136..b4fc94f2a4 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -704,6 +704,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
  
      /* 470 */
      QEMU_CAPS_MIGRATE_INCOMING_EXIT_ON_ERROR, /* exit-on-error argument of migrate-incoming command */
+    QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW, /* -device virtio-mem-ccw */
  
      QEMU_CAPS_LAST /* this must always be the last item */
  } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml b/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml
index 242848d6ae..bccce19bfc 100644
--- a/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml
@@ -141,6 +141,7 @@
    <flag name='netdev-stream-reconnect-miliseconds'/>
    <flag name='query-cpu-model-expansion.deprecated-props'/>
    <flag name='migrate-incoming.exit-on-error'/>
+  <flag name='virtio-mem-ccw'/>
    <version>9002050</version>
    <microcodeVersion>39100285</microcodeVersion>
    <package>v9.2.0-1203-gd6430c17d7</package>


--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294







