Re: [PATCH 2/5] qemuProcessHandleIOError: Fix logic for lookup of disk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 24, 2025 at 17:33:03 +0100, Peter Krempa wrote:
> There are two bugs in the current disk lookup code in
> qemuProcessHandleIOError:
> 
>  1) The QOM name isn't matched qemuProcessFindDomainDiskByAliasOrQOM()
> 
>    We pass NULL as the second argument, but the diskAlias argument can
>    be the QOM path for e.g. virtio disks. This means that the IO error
>    event doesn't actually contain the disk information:

I've found the root cause for this one to be in QEMU where starting from
qemu-9.2 a 'qom-path' field was introduced for the event in qemu, but it
was plumbed in wrong where the 'device' and 'qom-path' fields were
exchanged.

Based on that I'll slightly modify this patch to also take QOM path if
present and plumb it in properly via an explicit path rather than how
this patch did it.

I'll also post a patch fixing the qemu bug.



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux