On Thu, Jan 23, 2025 at 02:51:50PM -0300, Daniel Henrique Barboza wrote:
On 1/23/25 1:15 PM, Andrea Bolognani wrote:On Thu, Jan 23, 2025 at 03:40:40PM +0100, Martin Kletzander wrote:On Thu, Jan 23, 2025 at 09:17:25AM -0300, Daniel Henrique Barboza wrote:Daniel Henrique Barboza (4): qemu: add capability for RISC-V AIA feature conf,qemu: implement RISC-V 'aia' virt domain feature qemu: add RISC-V 'aia' command line .mailmap: add my contact infoTo all four patches: Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>Feel free to add my Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> as well. I had marked this series for review but then failed to get back to it, thanks a lot Martin for stepping up!Thanks! Should I go ahead and push it (I think I still have write access to the repo) or do you guys handle it?
Sure, go ahead.
Just one question: is there a way to figure out what the default for the machine type will be ahead of time so that we can record that information in the XML when the domain is defined? I'm assuming that changing the value has user-visible consequences...Unless we have a way of querying machine properties in QEMU I don't think we have a way of knowing beforehand the default for this particular prop (or any other machine prop for that matter). We have QEMU apis such as 'query-current-machine' that could be used for this purpose, I guess ...
Oh, that's the one thing I wanted to mention and forgot. If we have a way to query that information even after starting the guest then it would be nice to update the XML so that we keep the same default (even though it probably will be kept stable thanks to the machine type). What that would help with is when potentially migrating (or restoring from a managed save) specifying the same value would not trigger the ABI compatibility error. But that's a pretty niche case I guess.
Thanks, Daniel
Attachment:
signature.asc
Description: PGP signature
