On 1/23/25 6:18 AM, Martin Kletzander wrote:
On Wed, Jan 22, 2025 at 12:16:59PM -0300, Daniel Henrique Barboza wrote:
At this moment it is not possible to launch a 'riscv64' domain if a CPU
definition is presented in the domain. For example, adding this CPU
definition:
<cpu mode='custom' match='exact' check='none'>
<model fallback='forbid'>rv64</model>
</cpu>
Will trigger the following error:
$ sudo ./run tools/virsh start riscv-virt1
error: Failed to start domain 'riscv-virt1'
error: this function is not supported by the connection driver:
cannot update guest CPU for riscv64 architecture
The error comes from virCPUUpdate(), via qemuProcessUpdateGuestCPU(),
and it's caused by the absence of the 'update' API in the existing
RISC-V driver.
Add an 'update' API impl to the RISC-V driver to allow for CPU
definitions to be declared in RISC-V domains. This API was copied from
the ARM driver (virCPUarmUpdate()) since it's a good enough
implementation to get us going.
Signed-off-by: Daniel Henrique Barboza <dbarboza@xxxxxxxxxxxxxxxx>
I presume this patch was left formatted in your repo and accidentally
sent with something like `git send-email *patch`, since it's already
merged for quite some time =)
Oooops :(
Anyway, thanks to it I noticed the change in your e-mail address, so you
might want to update .mailmap to your satisfaction.
I wasn't aware of this file. I'll take a look and update as needed. Thanks,
Daniel
Martin
