Re: [PATCH] tests: Skip daemon-conf test if dir exceeds UNIX_PATH_MAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/17/2010 11:29 AM, Eric Blake wrote:
>> +if test ${#SOCKPATH} -lt 108 ; then
> 
> Bash-ism.  To be portable, you'd have to use something like:
> 
> if test `echo "$SOCKPATH" | wc -c` -lt 108; then

Huh, I stand (partially) corrected.  POSIX requires support for ${#foo}.
 If we were to use gnulib's init.sh, we would then have the guarantee
that we have enough of a POSIX environment to rely on that particular
construct.  But right now, test-lib.sh doesn't quite guarantee
everything provided in gnulib.

Jim, is it time to modify test-lib.sh to borrow more ideas from gnulib's
init.sh?

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]