On Wed, Jan 15, 2025 at 11:34:05AM +0100, Boris Fiuczynski wrote: > Allows for the query of hypervisor-known CPU models via the simple > command: virsh hypervisor-cpu-models. For the QEMU driver, the models > are queried via the capabilities file. Each model is printed to the > terminal on its own line similar to the cpu-models command, and there > is no order to the listing. This is just duplicating what we already expose to users in virConnectGetDomainCapabilities / virsh domcapabilities. eg # virsh domcapabilities --xpath '//cpu//model/text()' Snowridge qemu64 qemu32 phenom pentium3 pentium2 pentium n270 kvm64 kvm32 coreduo core2duo athlon Westmere-IBRS Westmere Snowridge Skylake-Server-noTSX-IBRS Skylake-Server-IBRS Skylake-Server Skylake-Client-noTSX-IBRS Skylake-Client-IBRS Skylake-Client SapphireRapids ...snip... Yes, we currently have a virConnectGetCPUModelNames(), but when we introduced the new QEMU-detectectable CPU support, we intended for the virConnectGetDomainCapabilities API to replace the former use case, so didn't add a new CPUModelNames API With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|