On 1/10/25 3:44 AM, Leigh Brown wrote:
Hi Laine,
On 2025-01-08 22:33, Laine Stump wrote:
On 1/8/25 8:31 AM, Leigh Brown wrote:
I have incorporated Laine's feedback and added Reviewed-by tags. I also
noticed that I hadn't updated the patch series description, so I updated
it to reflect the change to using netlink, for posterity.
Okay, I've gone through all of these again, fixed a few conditionals
that should have had braces but didn't (in patch 2), and removed one
change that I'd mistakenly requested (in patch 3 - I commented in a
reply to that), and pushed it all. Thanks for the contribution! (and
for your patience, and for being so quick responding to reviews with a
new spin :-)
Thanks for merging. I am very happy. I'm running 11.0.0-rc1 on my two
servers right now.
Tomorrow I'll add an entry to NEWS.rst and also send a patch for the
minor update that's needed to qemuChangeNet()
I notice you didn't apply the fourth (documentation) patch - just
checking if that was on purpose.
No, that was completely an accident! I recall I accidentally git merged
the patch just after yours without first rebasing its branch, so I had
to git reset --hard my local master, rebase, and do it over; possibly I
accidentally backed up one patch too far :-/
Anyway, thanks for noticing that! It's not a problem to push
documentation changes during freeze, so I'll do that tonight, and also
write up the other two patches I'd promised.
