Dear Daniel Thank you for your comment. > This ought to be split up into some separate parts. I will split the patch into separate features and repost them. > also the domain XML schema additions should get a test case added to qemuconftest. I will add test case for schema. > Will be 11.1.0 at the earliest now, but I presume delays on the QEMU side are going to hold us up from merging a good while longer than that. Understood. > ccaMeasurementAlgo is an array of strings, so this frees the array but leaks the strings. Make sure to free memory of string too in the next version. > This is copynig the string pointer without duplicating it, which will cause a double-free if you fix the missing 'free' calls for virCCACapability I mention earlier Ok, I will make sure to avoid double-free. Best Regards.