On 1/8/25 11:04, Daniel P. Berrangé wrote: > On Wed, Jan 08, 2025 at 10:56:21AM +0100, Michal Privoznik wrote: >> Nothing inside libvirt-admin library calls devmapper nor it >> should. This is a historic artefact that was just copied over >> from autotools era. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> >> NB, I think there are more deps that can be dropped. I've built >> successfully with capng_dep, gnutls_dep, json_c_dep, libssh2_dep, >> libssh_dep and sasl_dep removed. Those libraries are required by >> libvirt.so which libvirt_admin.so links with. > > Beware that on some platforms libvirt-admin.so's usage could be satisfied > indirectly by libraries libvirt.so links to, but on other platforms > libvirt-admin.so would require direct linkage. We've seen this periodically > in the past with things that link fine on Fedora, breaking on Debian/Ubuntu, > but I'm not sure if that difference in behaviour still exists today. Just ran this patch through our CI and it looks like it works: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1615986790 and I totally agree with your reasoning, that's why I'm not removing any of the other deps. Michal
