On 1/3/25 14:22, Adam Julis wrote: > Resolves: https://issues.redhat.com/browse/RHEL-72192 > Signed-off-by: Adam Julis <ajulis@xxxxxxxxxx> > --- > docs/formatdomain.rst | 2 +- > src/qemu/qemu_validate.c | 11 ----- > src/qemu/qemu_virtiofs.c | 3 ++ > .../vhost-user-fs-readonly.x86_64-latest.args | 34 ++++++++++++++ > .../vhost-user-fs-readonly.x86_64-latest.err | 1 - > .../vhost-user-fs-readonly.x86_64-latest.xml | 45 +++++++++++++++++++ I'd rather make this a symlink to the original .xml file since there's no difference. > .../vhost-user-fs-readonly.xml | 1 + > tests/qemuxmlconftest.c | 2 +- > 8 files changed, 85 insertions(+), 14 deletions(-) > create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-readonly.x86_64-latest.args > delete mode 100644 tests/qemuxmlconfdata/vhost-user-fs-readonly.x86_64-latest.err > create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-readonly.x86_64-latest.xml > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 8d787ef59a..e8e8336708 100644 > --- a/docs/formatdomain.rst > +++ b/docs/formatdomain.rst > @@ -3824,7 +3824,7 @@ A directory on the host that can be accessed directly from the guest. > :since:`Since 10.0.0` > ``readonly`` > Enables exporting filesystem as a readonly mount for guest, by default > - read-write access is given (currently only works for QEMU/KVM driver; not > + read-write access is given (works for QEMU/KVM driver and :since:`Since 11.0.0` > with virtiofs). This was implemented in virtiofsd by the following commit: https://gitlab.com/virtio-fs/virtiofsd/-/commit/782d8e1f which is contained in v1.13.0 release. I'd rather make this obvious in the docs. The other option is to extend virtiofsd capabilities we query (qemuVhostUserFSFeature) which seems a bit overkill. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
