On Thu, Nov 28, 2024 at 16:28:09 +0300, Alexander Kuznetsov wrote:
> This function return value is invariant since 18f3771, so change
> its type and remove all dependent checks.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Reported-by: Pavel Nekrasov <p.nekrasov@xxxxxxxxxxx>
> Signed-off-by: Alexander Kuznetsov <kuznetsovam@xxxxxxxxxxxx>
> ---
> src/hypervisor/virhostdev.c | 3 +--
> src/util/virscsivhost.c | 6 ++----
> src/util/virscsivhost.h | 2 +-
> 3 files changed, 4 insertions(+), 7 deletions(-)
>
...
> diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c
> index 15024d7106..05b89e58d6 100644
> --- a/src/util/virscsivhost.c
> +++ b/src/util/virscsivhost.c
...
> @@ -214,7 +212,7 @@ virSCSIVHostDeviceGetUsedBy(virSCSIVHostDevice *dev,
> {
> *drv_name = dev->used_by_drvname;
> *dom_name = dev->used_by_domname;
> - }
> +}
This is completely unrelated to what this patch is doing.
Jirka
