On 11/26/24 11:59 AM, Jiri Denemark wrote: > On Mon, Nov 25, 2024 at 14:46:34 -0500, Collin Walling wrote: >> # Changelog >> >> v2 >> - rebased on latest master changes > > I started reviewing the v1 yesterday with a plan to push this in time > for the release, but I found a few issues and got sidetracked by > investigating why the issues were not caught by our unit tests. They are > actually visible when running qemucapabilitiestest in valgrind, normally > everything passes just fine :-/ I'm copying my notes for v1 here. > > Jirka Whoops, thought I had replied! Apologies. Thanks for taking the due-diligence to check on this. I'll have the next iteration that addresses this and other review soon. -- Regards, Collin