Eric Blake wrote:
> On 05/17/2010 06:08 AM, Jim Meyering wrote:
>> Here's another fix for a potential NULL-deref.
>> x86cpuidFind can return NULL, yet this caller
>> would dereference that pointer (via x86cpuidMatchMasked)
>> without first checking.
>>
>> for (i = 0; i < feature->ncpuid; i++) {
>> cpuid = feature->cpuid + i;
>> model_cpuid = x86cpuidFind(model->cpuid, model->ncpuid,
>> cpuid->function);
>> - if (!x86cpuidMatchMasked(model_cpuid, cpuid))
>> + if (!model_cpuid || !x86cpuidMatchMasked(model_cpuid, cpuid))
>
> ACK.
Thanks. Pushed.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list