On Thu, Nov 28, 2024 at 10:16:10 +0100, Jiri Denemark wrote: > On Tue, Nov 26, 2024 at 16:16:16 +0100, Peter Krempa wrote: > > For the reason outlined in previous commit qemu doesn't do this > > automatically. Handle it manually after the snapshot. > > > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > --- > > src/qemu/qemu_snapshot.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c > > index 5b3aadcbf0..f880d1eeec 100644 > > --- a/src/qemu/qemu_snapshot.c > > +++ b/src/qemu/qemu_snapshot.c > ... > > @@ -1470,6 +1477,7 @@ qemuSnapshotDiskUpdateSource(virDomainObj *vm, > > dd->persistsrc->backingStore = g_steal_pointer(&dd->persistdisk->src); > > dd->persistdisk->src = g_steal_pointer(&dd->persistsrc); > > } > > + > > } > > Looks like an accidental change, which was not supposed to be included in > the commit. Indeed. It was the place where I put the code originally, later realizing that it doesn't make sense :)