On Mon, May 17, 2010 at 08:36:59AM -0600, Eric Blake wrote: > On 05/16/2010 03:24 AM, Daniel P. Berrange wrote: > >> > >> * acinclude.m4 (LIBVIRT_COMPILE_WARNINGS): Define WARN_LDFLAGS as > >> an alias for WARN_CFLAGS. > >> +++ b/acinclude.m4 > >> @@ -78,7 +78,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ > >> AC_MSG_RESULT($complCFLAGS) > >> > >> WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS" > >> - AC_SUBST(WARN_CFLAGS) > >> + AC_SUBST([WARN_CFLAGS]) > >> + AC_SUBST([WARN_LDFLAGS]) > > > > Where is WARN_LDFLAGS actually defined ? This looks like it > > is just setting it to empty string ? > > Good catch. I'm squashing this in; do you need to see the revised patch > before giving an ACK? > > diff --git i/acinclude.m4 w/acinclude.m4 > index f048879..8c97184 100644 > --- i/acinclude.m4 > +++ w/acinclude.m4 > @@ -78,6 +78,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ > AC_MSG_RESULT($complCFLAGS) > > WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS" > + WARN_LDFLAGS=$WARN_CFLAGS > AC_SUBST([WARN_CFLAGS]) > AC_SUBST([WARN_LDFLAGS]) ACK, that's fine as an addition Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list