We don't change definitions of CPU models which were already included in a libvirt release to maintain migration compatibility. Thus the script can just skip existing models and save us from having to drop the changes it would do to them. Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> --- Notes: Version 2: - no change src/cpu_map/sync_qemu_models_i386.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cpu_map/sync_qemu_models_i386.py index 78c2bffab2..f7b06a7716 100755 --- a/src/cpu_map/sync_qemu_models_i386.py +++ b/src/cpu_map/sync_qemu_models_i386.py @@ -535,6 +535,10 @@ def main(): for model in models: name = os.path.join(args.outdir, f"x86_{model['name']}.xml") + if os.path.isfile(name): + # Ignore existing models as CPU models in libvirt should never + # change once released. + continue with open(name, "wt") as f: output_model(f, model) -- 2.47.0