On Thu, Nov 21, 2024 at 14:02:22 +0000, Daniel P. Berrangé wrote: > On Thu, Nov 21, 2024 at 02:35:34PM +0100, Jiri Denemark wrote: > > On Wed, Nov 20, 2024 at 12:11:19 +0000, Daniel P. Berrangé wrote: > > > On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote: > > > > We already visually group the included models according to vendor using > > > > comments. This patch introduces a new <group> element for doing it > > > > properly in a machine friendly way. > > > > > > AFAICT the <group> has no functional effect > > > > > > If we're just going to group everything based on vendor, > > > why not just call the tag <vendor name=...> ? > > > > We can't use just vendor because some models (the old ones) don't have a > > vendor. We could perhaps use something like vendor='generic', > > vendor='QEMU' or something similar, although using the complete text > > from the comment makes reading a bit easier for people. > > From QEMU's POV every model has a vendor. Yeah, I was talking about our POV. Also the point of this patch was not really to change grouping, just mark the groups in some way the script can properly recognize them. I think the current groups are good enough. Jirka
