On Wed, Nov 20, 2024 at 02:32:42PM +0100, Jiri Denemark wrote: > On Wed, Nov 20, 2024 at 10:23:55 +0000, Daniel P. Berrangé wrote: > > FYI, I re-ran the sync script after applying this series: > > > > ./src/cpu_map/sync_qemu_models_i386.py ../qemu src/cpu_map > > > > and it adds a bunch more CPUs from QEMU git master. > > > > <include filename='x86_GraniteRapids-v1.xml'/> > > <include filename='x86_SierraForest.xml'/> > > <include filename='x86_SierraForest-v1.xml'/> > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_GraniteRapids-v2.xml'/> > > This is a new version added in 9.2.0, while I explicitly wanted to only > add released CPU model, i.e., used 9.1.*. Since 9.2.0 is in rc phase > already I guess I could add this v2 as well. There's a small chance someone could appear with a bugfix for -v2 before 9.2.0 GA release. Skip it for Dec 1st release, and we can have it in the Jan 15th release. > > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_Denverton.xml'/> > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_Denverton-v1.xml'/> > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_Denverton-v2.xml'/> > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_Denverton-v3.xml'/> > > + <include filename='/var/home/berrange/src/virt/libvirt/src/cpu_map/x86_KnightsMill.xml'/> > > This series is adding versioned variants to existing CPU models, while > Denverton and KnightsMill were never supported by libvirt. I don't think > they need to be added (Denverton is an Atom CPU and KnightsMill is some > kind of a dead evolution branch), but we can just add them for > consistency. For the sake of just 5 extra CPU xmls, out of 130, I think it is not worth making an exception by excluding them. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
