Re: [PATCH v5 10/18] qemu: helper: throttle filter nodename and preparation processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 18, 2024 at 19:24:18 +0530, Harikumar R wrote:

[...]

> ---
>  src/qemu/qemu_block.c   | 136 ++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_block.h   |  49 +++++++++++++++
>  src/qemu/qemu_command.c |  81 ++++++++++++++++++++++++
>  src/qemu/qemu_command.h |   6 ++
>  src/qemu/qemu_domain.c  |  73 +++++++++++++++++++--
>  5 files changed, 341 insertions(+), 4 deletions(-)

Note this is a preliminary comment; please don't send an updated
version just because of this:

Fails to compile:

../../../libvirt/src/qemu/qemu_domain.c: In function ‘qemuDomainPrepareDiskSourceBlockdev’:
../../../libvirt/src/qemu/qemu_domain.c:9708:12: error: unused variable ‘i’ [-Werror=unused-variable]
 9708 |     size_t i;
      |            ^
../../../libvirt/src/qemu/qemu_domain.c: In function ‘qemuDomainPrepareDiskSource’:
../../../libvirt/src/qemu/qemu_domain.c:9754:10: error: ‘i’ undeclared (first use in this function); did you mean ‘ip’?
 9754 |     for (i = 0; i < disk->nthrottlefilters; i++) {
      |          ^
      |          ip

"If you're going to submit multiple patches, the automated tests must
pass after each patch, not just after the last one."

https://www.libvirt.org/hacking.html#preparing-patches




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux