On Thu, Nov 07, 2024 at 03:54:34PM +0000, Daniel P. Berrangé wrote: > On Thu, Nov 07, 2024 at 04:46:07PM +0100, Andrea Bolognani wrote: > > +++ b/docs/formatdomain.rst > > @@ -3931,7 +3931,7 @@ machine types, accept the following ``model`` values: > > into a PCI Express slot, and like a ``virtio-transitional`` device otherwise; > > libvirt will pick one or the other based on the machine type. This is the > > best choice when compatibility with libvirt versions older than 5.2.0 is > > - necessary, but it's otherwise not recommended to use it. > > + necessary or if you're unsure which of the other two options to pick. > > I would go even further than this. > > IMHO the list should be re-ordered to put 'virtio' first, and then say > > This is the recommended choice, in the absence of any guest OS > specific constraints, providing compatibility with libvirt > versions older than 5.2.0. I toyed with that idea before ultimately going for the version I posted. Given your support for that approach, I'll take another stab at it. -- Andrea Bolognani / Red Hat / Virtualization
