Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx> writes: > That's a first step to move on newer job-* APIs. > > The difference between block-job-change and job-change is in > find_block_job_locked() vs find_job_locked() functions. What's > different? > > 1. find_block_job_locked() finds only block jobs, whereas > find_job_locked() finds any kind of job. job-change is a > compatible extension of block-job-change. > > 2. find_block_job_locked() reports DeviceNotActive on failure, when > find_job_locked() reports GenericError. Since the kind of error > reported isn't documented for either command, and clients > shouldn't rely on undocumented error details, job-change is a > compatible replacement for block-job-change. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx> Acked-by: Markus Armbruster <armbru@xxxxxxxxxx>