On Tue, Oct 29, 2024 at 10:51:57AM -0400, Laine Stump wrote: > On 10/29/24 9:14 AM, Daniel P. Berrangé wrote: > > We cannot ship the forthcoming libvirt release with a checksum "fix" > > that breaks all usage of NICs that aren't virtio-net, as that guarantees > > brokeness for all historical OS. > > > > If we can't quickly find a way to improve this, I think we need to > > revert (or disable) the checksum zero'ing fix for this release and > > spend more time investigating it. > > I sadly agree :-/ (although I will point out that it's not *all* non-virtio, > since e1000e seems to work). I am leaving the house now, but will make a > patch to either disable or the revert the "fix" when I get back in a few > hours. (I would rather leave it in with a switch or something so we could > continue using standard builds to test things, but that might take too long > and would definitely be too complicated for a last instant push) I vote against adding yet another knob. If we can't fix things in time, let's just revert the change and work on a fully working solution over the next development cycle. -- Andrea Bolognani / Red Hat / Virtualization
