[PATCH] virJSONValueFromString: Prefix error message from 'json-c'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The error message from 'json-c' was passed along without any libvirt
string which makes it hard to find in the source and isn't exactly clear
when present in logs:

 libvirtd[843]: internal error : invalid utf-8 string

Prefix the message with 'failed to parse JSON'.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
 src/util/virjson.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/virjson.c b/src/util/virjson.c
index 42018a98b4..4a95e84f5b 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -1467,7 +1467,8 @@ virJSONValueFromString(const char *jsonstring)
     jerr = json_tokener_get_error(tok);
     if (jerr != json_tokener_success) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
-                       "%s", json_tokener_error_desc(jerr));
+                       _("failed to parse JSON: %1$s"),
+                       json_tokener_error_desc(jerr));
         goto cleanup;
     }
     ret = virJSONValueFromJsonC(jobj);
-- 
2.47.0




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux